Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support 1.21.1 #2877

Merged
merged 3 commits into from
Aug 11, 2024
Merged

Support 1.21.1 #2877

merged 3 commits into from
Aug 11, 2024

Conversation

PierreSchwang
Copy link
Member

Overview

Fixes #2876

Description

Allow the new 1.21.1 dataversion for the 1.21 adapter. EntityList got removed, so I've added reflection calls (I'm actually not even sure if there is a paper jar without the new chunk system - but no idea how forks handle that). Should work - but I haven't tested that (as I don't even know how). 1.21.1 works so far. Haven't explicitly tested 1.21

Submitter Checklist
Beta Give feedback

@PierreSchwang PierreSchwang requested a review from a team as a code owner August 10, 2024 23:37
@github-actions github-actions bot added the chore label Aug 10, 2024
@PierreSchwang PierreSchwang mentioned this pull request Aug 11, 2024
Closed
1 task
@SirYwell
Copy link
Member

The list was moved to ca.spottedleaf.moonrise.common.list.EntityList, but it should be fine just removing that part, the entities method in LevelChunk is definitely gone.

@NotMyFault NotMyFault added Major feature This PR adds a major feature and removed chore labels Aug 11, 2024
@github-actions github-actions bot added the chore label Aug 11, 2024
@PierreSchwang PierreSchwang marked this pull request as draft August 11, 2024 15:48
@PierreSchwang PierreSchwang marked this pull request as ready for review August 11, 2024 15:54
@github-actions github-actions bot added the chore label Aug 11, 2024
@PierreSchwang
Copy link
Member Author

The list was moved to ca.spottedleaf.moonrise.common.list.EntityList, but it should be fine just removing that part, the entities method in LevelChunk is definitely gone.

Fair. I've removed the references to the references to the old chunk system. Basic //air on a few mill blocks worked in 1.21 and 1.21.1 (both latest paper). Not sure what a good test case would be there.

SirYwell
SirYwell approved these changes Aug 11, 2024
View reviewed changes
Copy link
Member

@SirYwell SirYwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work as far as I tested.

@NotMyFault NotMyFault merged commit 41d294e into main Aug 11, 2024
11 checks passed
@NotMyFault NotMyFault deleted the chore/1.21.1 branch August 11, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SirYwell SirYwell SirYwell approved these changes

@NotMyFault NotMyFault NotMyFault approved these changes

Assignees
No one assigned
Labels
Major feature This PR adds a major feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

1.21.1 is unsupported.
3 participants
@PierreSchwang @SirYwell @NotMyFault